Skip to content

Conversation

@giordano
Copy link
Member

@giordano giordano commented Feb 3, 2025

Reverts #57234.

This was merged despite having broken tests failing repeatedly #57234 (comment)

@giordano
Copy link
Member Author

giordano commented Feb 3, 2025

Presumably broken by JuliaLang/LinearAlgebra.jl#1166 since it touches code around the failing test. CC @ViralBShah

@ViralBShah
Copy link
Member

I had run it again and it gave all green. I'll look into this again - in the meanwhile yes, let's revert.

@ViralBShah
Copy link
Member

Let's hold a little bit - since we have a LinearAlgebra.jl fix: JuliaLang/LinearAlgebra.jl#1192

@ViralBShah
Copy link
Member

The PR that includes the fix is #57247

@IanButterworth
Copy link
Member

#57247 has been merged

@IanButterworth IanButterworth deleted the revert-57234-BumpStdlibs/LinearAlgebra-c9ad828-master branch February 4, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants