compiler: eliminate most of unused variables in the compiler #59202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by opening the compiler folder with JETLS.
topolarity
reviewed
Aug 4, 2025
| @@ -3081,7 +3079,7 @@ end | |||
| function abstract_eval_new(interp::AbstractInterpreter, e::Expr, sstate::StatementState, | |||
| sv::AbsIntState) | |||
| 𝕃ᵢ = typeinf_lattice(interp) | |||
| rt, isexact = instanceof_tfunc(abstract_eval_value(interp, e.args[1], sstate, sv), true) | |||
There was a problem hiding this comment.
Is it worth using a convention that some other languages use and allowing the variable to be unused if it is prefixed with _? (_isexact in this case)
seems a minor shame to lose the info about what this value is just because it is unused, esp. if it becomes used in the future
There was a problem hiding this comment.
I'd be OK with this. It doesn't even need to be a real convention, just a JETLS one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by opening the compiler folder with JETLS.