compiler: consolidate staticdata.jl and invalidations.jl into Compiler proper [NFCI] #59238
+71
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r proper We actually might want a `Base.CompilerUtils` module so that the `Compiler` package itself is smaller and less reliant on internal APIs, but for now just move these into a submodule of Compiler. These are supposed to call back into (and be called by) inference quite heavily in the future, so it makes more sense (and is necessary for the world-age) for them to actually be part of inference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to consolidate more of the code that is expected to run in typeinf_world into Compiler proper. The intent is that these are likely to gain more interaction (both directions) with inference, as the compiler should use this mini-compiler and vice versa.
We actually might want a
Base.CompilerUtilsmodule so that theCompilerpackage itself is smaller and less reliant on internal APIs, but for now just move these into a submodule of Compiler.