Rewrite most gensym macros to use automatic hygiene instead #59239
+276
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows using meta.jl much earlier in the build (instead of importing these from show.jl).
vtjnash
changed the title
vtjnash
added
compiler:lowering
Manual `gensym` code often contains a lot of mistakes, either because the user uses something like `.` or `+`, or because it combines code from multiple modules (gensym is only unique within a pre-compile unit). This replaces most uses for macro local variables with proper scope markers. I did not rewrite `_lift_one_interp_helper` or `replace_ref_begin_end_` however, since, while possible by adding `esc` to every argument that has not used a gensym value, if any other argument did is a value, I worried that could lead to macroexpand.scm making more new mistakes so I left if for a separate PR. Better yet, we could make a unhygienic-scope and unescape pair for marking the inverse/dual of the usual operations (marking a symbol as unescaped within a region of unhygienic (escaped) code to make these various uses easier to implement. But rewrite `replace_ref_begin_end_` to respect argument order and evaluation count (similar to its julia-syntax.scm counterpart) and scoping (not adding `let` unpredictably).
vtjnash
force-pushed
the
jn/gensym-deprecated
branch
from
4cf81b5 to
c244cf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual
gensymcode often contains a lot of mistakes, either because theuser uses something like
.or+, or because it combines code frommultiple modules (gensym is only unique within a pre-compile unit). This
replaces most uses for macro local variables with proper scope markers.
I did not rewrite
_lift_one_interp_helperorreplace_ref_begin_end_however, since, while possible by adding
escto every argument thathas not used a gensym value, if any other argument did is a value, I
worried that could lead to macroexpand.scm making more new mistakes so I
left if for a separate PR. Better yet, we could make a unhygienic-scope
and unescape pair for marking the inverse/dual of the usual operations
(marking a symbol as unescaped within a region of unhygienic (escaped)
code to make these various uses easier to implement.
But also do rewrite
replace_ref_begin_end_to respect argument orderand evaluation count (similar to its julia-syntax.scm counterpart) and
scoping (not adding
letunpredictably).