Skip to content

Remove restrictions on kwarg tab completion #59692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+48 −8
Open

Remove restrictions on kwarg tab completion #59692

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da0b845
Remove restrictions on tab completion
mbauman Sep 29, 2025
5e1722a
also remove outdated comment
mbauman Sep 29, 2025
e7dd145
Update stdlib/REPL/test/replcompletions.jl
mbauman Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions stdlib/REPL/src/REPLCompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,12 +901,6 @@ function complete_keyword_argument!(suggestions::Vector{Completion},
kwargs_flag == 2 && return false # one of the previous kwargs is invalid

methods = Completion[]
# Limit kwarg completions to cases when function is concretely known; looking up
# matching methods for abstract functions — particularly `Any` or `Function` — can
# take many seconds to run over the thousands of possible methods. Note that
# isabstracttype would return naively return true for common constructor calls
# like Array, but the REPL's introspection here may know their Type{T}.
isconcretetype(funct) || return false
complete_methods!(methods, funct, Any[Vararg{Any}], kwargs_ex, -1, arg_pos == :kwargs)
# TODO: use args_ex instead of Any[Vararg{Any}] and only provide kwarg completion for
# method calls compatible with the current arguments.
Expand Down
48 changes: 47 additions & 1 deletion stdlib/REPL/test/replcompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2687,10 +2687,56 @@ f54131 = F54131()

s = "f54131.x(kwa"
a, b, c = completions(s, lastindex(s), @__MODULE__, false)
@test_broken REPLCompletions.KeywordArgumentCompletion("kwarg") in a
@test REPLCompletions.KeywordArgumentCompletion("kwarg") in a
@test (@elapsed completions(s, lastindex(s), @__MODULE__, false)) < 1
end

@kwdef struct T59244
asdf = 1
qwer = 2
end
@kwdef struct S59244{T}
asdf::T = 1
qwer::T = 2
end
@testset "kwarg completion of types" begin
s = "T59244(as"
a, b, c = completions(s, lastindex(s), @__MODULE__, #= shift =# false)
@test REPLCompletions.KeywordArgumentCompletion("asdf") in a

s = "T59244(; qw"
a, b, c = completions(s, lastindex(s), @__MODULE__, #= shift =# false)
@test REPLCompletions.KeywordArgumentCompletion("qwer") in a
@test REPLCompletions.KeywordArgumentCompletion("qwer") == only(a)

s = "S59244(as"
a, b, c = completions(s, lastindex(s), @__MODULE__, #= shift =# false)
@test REPLCompletions.KeywordArgumentCompletion("asdf") in a

s = "S59244(; qw"
a, b, c = completions(s, lastindex(s), @__MODULE__, #= shift =# false)
@test REPLCompletions.KeywordArgumentCompletion("qwer") in a
@test REPLCompletions.KeywordArgumentCompletion("qwer") == only(a)

s = "S59244{Int}(as"
a, b, c = completions(s, lastindex(s), @__MODULE__, #= shift =# false)
@test REPLCompletions.KeywordArgumentCompletion("asdf") in a

s = "S59244{Int}(; qw"
a, b, c = completions(s, lastindex(s), @__MODULE__, #= shift =# false)
@test REPLCompletions.KeywordArgumentCompletion("qwer") in a
@test REPLCompletions.KeywordArgumentCompletion("qwer") == only(a)

s = "S59244{Any}(as"
a, b, c = completions(s, lastindex(s), @__MODULE__, #= shift =# false)
@test REPLCompletions.KeywordArgumentCompletion("asdf") in a

s = "S59244{Any}(; qw"
a, b, c = completions(s, lastindex(s), @__MODULE__, #= shift =# false)
@test REPLCompletions.KeywordArgumentCompletion("qwer") in a
@test REPLCompletions.KeywordArgumentCompletion("qwer") == only(a)
end

# Completion inside string interpolation
let s = "\"example: \$varflo"
c, r = test_complete_foo(s)
Expand Down