Skip to content

Make Base.get_extension private to prevent user mistakes #59708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Open

Make Base.get_extension private to prevent user mistakes #59708

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51d352d
Make `Base.get_extension` private to prevent user mistakes
vtjnash Sep 30, 2025
bafa9cc
Update public.jl
vtjnash Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1643,7 +1643,9 @@ end
"""
get_extension(parent::Module, extension::Symbol)

Return the module for `extension` of `parent` or return `nothing` if the extension is not loaded.
Return the module for `extension` relative to `parent` or return `nothing` if the extension is not loaded.
This function is private, since the arguments to it are private implementation details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In how far are the arguments private?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ext name is private, and the parent argument is used to extract PkgId which is internally also private

It is provided mainly for testing and reflection purposes.
"""
get_extension(parent::Module, ext::Symbol) = get_extension(PkgId(parent), ext)
function get_extension(parentid::PkgId, ext::Symbol)
Expand Down
1 change: 0 additions & 1 deletion base/public.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ public
active_project,

# Reflection and introspection
get_extension,
isambiguous,
isexpr,
isidentifier,
Expand Down
Loading