Adjust trimming test to JSON.jl ≥1.0#59738
Merged
topolarity merged 1 commit intomasterfrom Oct 3, 2025
Merged
Conversation
topolarity
added
ci
topolarity
force-pushed
the
ct/fix-trimming
branch
from
3679741 to
82bf5e7
Compare
Member
|
Oh hey, didn't realize there was a test on JSON for trimming here! I did run through a few trimming toy executables and made a few tweaks in the new 1.0 release to ensure trim verify worked. I think doing a plain |
Member
Author
|
This is not the trimmed executable itself, just a script that verifies the output of the trimmed program / JuliaC 😁 |
DilumAluthge
added a commit
that referenced
this pull request
Oct 4, 2025
`Libdl`, `Sockets`, and `Test` are non-upgradeable stdlibs that live in the JuliaLang/julia source tree, so I didn't include compat entries for them. `Zstd_jll` is vendored under `test/trimming/Zstd_jll`, and is included via `[sources]`, so I don't think we need a compat entry for that either. A compat entry for `JSON` was added in #59738. So that just leaves `JLLWrappers`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to major update of JSON.jl: JuliaIO/JSON.jl#374