release-1.12: backport memory improvements #60173
Draft
+627
−251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports our RTDyLD memory manager to JITLink in order to avoid memory use regressions after switching to JITLink everywhere (#60031). This is a direct port: finalization must happen all at once, because it invalidates all allocation `wr_ptr`s. I decided it wasn't worth it to associate `OnFinalizedFunction` callbacks with each block, since they are large enough to make it extremely likely that all in-flight allocations land in the same block; everything must be relocated before finalization can happen. (cherry picked from commit 6fa0e75)
Member
|
Without #60117, the only benefit is to non-macOS platforms where we use JITLink (aarch64 linux, riscv32/64 linux). I suppose that could be reason enough, since they are often very memory constrained. |
(cherry picked from commit d844566)
(cherry picked from commit 1f15990)
(cherry picked from commit 2c51764)
Also reuse already-computed ModuleInfo (cherry picked from commit be73aab)
(cherry picked from commit e64d4bd)
(cherry picked from commit 040d85f)
(cherry picked from commit 7809398)
(cherry picked from commit b66bc01)
(cherry picked from commit 57f420a)
KristofferC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 6fa0e75)
@xal-0 do you think it makes sense to put this into 1.12.