Skip to content

Use error hints for convert and (::Type)(args...) MethodErrors #60188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −11
Open

Use error hints for convert and (::Type)(args...) MethodErrors #60188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions base/errorshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,15 +394,26 @@ function showerror(io::IO, ex::MethodError)
"\nYou can convert to a column vector with the vec() function.")
end
end
Experimental.show_error_hints(io, ex, san_arg_types_param, kwargs)
try
show_method_candidates(io, ex, kwargs)
catch ex
@error "Error showing method candidates, aborted" exception=ex,catch_backtrace()
end
Experimental.show_error_hints(io, ex, san_arg_types_param, kwargs)
nothing
end

Experimental.register_error_hint(MethodError) do io, exc, argtypes, kwargs
if exc.f == convert && Core._hasmethod(Tuple{argtypes...}) && length(argtypes) ≥ 1 && (argtypes[1] isa Type)
args = join(("::$(T)" for T ∈ argtypes[2:end]), ", ")
fstr = argtypes[1].parameters[1]
println(io, "\nHint: Did you mean to call $(fstr)($args) ?")
elseif exc.f isa Type && hasmethod(convert, Tuple{Type{exc.f}, argtypes...})
args = join(("::$(T)" for T ∈ argtypes), ", ")
println(io, "\nHint: Did you mean to call convert($(exc.f), $args) ?")
end
end

function showerror(io::IO, exc::FieldError)
@nospecialize
print(io, "FieldError: type $(exc.type.name.wrapper) has no field `$(exc.field)`")
Expand Down Expand Up @@ -471,16 +482,6 @@ function show_method_candidates(io::IO, ex::MethodError, kwargs=[])
f isa Core.Builtin && return # `methods` isn't very useful for a builtin
funcs = Tuple{Any,Vector{Any}}[(f, arg_types_param)]

# An incorrect call method produces a MethodError for convert.
# It also happens that users type convert when they mean call. So
# pool MethodErrors for these two functions.
if f === convert && !isempty(arg_types_param)
at1 = arg_types_param[1]
if isType(at1) && !has_free_typevars(at1) && at1.parameters[1] isa Type
push!(funcs, (at1.parameters[1], arg_types_param[2:end]))
end
end

for (func, arg_types_param) in funcs
for method in methods(func)
buf = IOBuffer()
Expand Down