Skip to content

Set max_methods for lock and unlock to 1 #60803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JamesWrigley wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set max_methods for lock and unlock to 1 #60803

JamesWrigley wants to merge 1 commit into from
+2 −0

Conversation

@JamesWrigley
Copy link
Member

@JamesWrigley JamesWrigley commented Jan 23, 2026

This should prevent invalidations, particularly in IJulia:

 inserting lock(io::IJulia.IJuliaStdio) @ IJulia ~/git/IJulia.jl/src/stdio.jl:17 invalidated:
   backedges: 1: superseding lock(::IO) @ Base io.jl:33 with MethodInstance for lock(::IO) (150 children)

 inserting unlock(io::IJulia.IJuliaStdio) @ IJulia ~/git/IJulia.jl/src/stdio.jl:18 invalidated:
   backedges: 1: superseding unlock(::IO) @ Base io.jl:34 with MethodInstance for unlock(::IO) (2275 children)

See for example: JuliaLang/IJulia.jl#1192 (comment)

@JamesWrigley
Set max_methods for lock and unlock to 1
74b0cc8 
This should prevent invalidations, particularly in IJulia.
@nsajko
Copy link
Member

nsajko commented Jan 24, 2026

xref PR #59377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vtjnash vtjnash

Labels

invalidations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamesWrigley @nsajko @vtjnash