Compiler: add smalltags for IR node types and optimize _useref_getindex #60831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add small tags for IR node types commonly used in `_useref_getindex`: Argument, GotoIfNot, ReturnNode, EnterNode, PiNode, PhiNode, PhiCNode, UpsilonNode, GlobalRef, GotoNode, and QuoteNode. This enables the compiler to generate efficient switch statements based on the type tags instead of pointer comparisons. Also split `_useref_getindex` into separate `op==1` and `op>1` paths. Most IR node types only have a single operand, so the `op==1` path can return directly without redundant `op == 1 || return OOB_TOKEN` checks. The `op>1` path only handles types that can have multiple operands (Expr, PhiNode, PhiCNode). Co-Authored-By: Claude Opus 4.5 <[email protected]>
gbaraldi
force-pushed
the
gbaraldi/smalltags-ir-types
branch
from
f629ef0 to
6d9d7cd
Compare
KristofferC
reviewed
Jan 26, 2026
| end | ||
| end | ||
|
|
||
| @noinline function _useref_getindex_op1(@nospecialize(stmt)) |
Member
There was a problem hiding this comment.
Could it potentially be worth to inline this if most nodes have op==1?
Member
Author
There was a problem hiding this comment.
It's a pretty bulky function so it's a bit unclear if there are too many wins. And we don't want a bunch of copies of it around using icache space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_useref_getindex: Argument, GotoIfNot, ReturnNode, EnterNode, PiNode, PhiNode, PhiCNode, UpsilonNode, GlobalRef, GotoNode, and QuoteNode_useref_getindexinto separateop==1andop>1paths to avoid redundant comparisonsTest plan
🤖 Generated with Claude Code