REPL: Fix Ctrl-A behavior after multiline history recall #60838
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where pressing Ctrl-A after recalling multi-line history with Ctrl-Up would incorrectly jump to the beginning of the entire input instead of the beginning of the current line. The issue was that history_prev() and history_next() used a temporary key_repeats reset (via reset_key_repeats helper) that didn't also reset previous_key. This left stale key state that caused the first keystroke after history recall to be incorrectly treated as a repeated key, triggering the 'jump to input start' behavior instead of 'go to line start'. The fix replaces the temporary reset with a permanent reset of both key_repeats and previous_key, which is semantically correct since history recall creates a fresh editing context. Changes: - stdlib/REPL/src/REPL.jl: Modified history_prev() and history_next() to permanently reset key_repeats and previous_key - stdlib/REPL/test/repl.jl: Added regression test to verify key_repeats and previous_key are reset after history recall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recalling a multiline history entry,
key_repeatscould remain non-zero,causing Ctrl-A to be interpreted as a repeated key press. This resulted in the
cursor jumping to the start of the entire input on first Ctrl-A.
This change ensures that:
Ctrl-A once moves to the start of the current line
Repeated Ctrl-A still moves to the start of the input
#AI tools were used to assist with code exploration and reasoning; all changes were implemented and verified manually.
Fixes #60779