Compiler: optimize scan_specified_partitions #60852
Open
+34
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove @isdefined checks from scan_specified_partitions by restructuring the loop to always initialize variables on the first iteration. This avoids the overhead of throw_undef_if_not checks in the generated code. Also add @inline annotations to walk_binding_partition, query calls, and WorldRange union/intersect functions to enable better optimization. The function now: - Processes the first partition outside the loop to initialize variables - Uses local variables for frequently accessed values (wwr_min, wwr_this) - Tracks total_min separately to avoid repeated min_world() calls Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove @isdefined checks from scan_specified_partitions by restructuring
the loop to always initialize variables on the first iteration. This
avoids the overhead of throw_undef_if_not checks in the generated code.
Co-Authored-By: Claude Opus 4.5 [email protected]
The
@isdefinedthing while cute, turns out LLVM made a mess of it and made the control flow of the function a lot more complex than it needs to be, so just manually unroll the functionSaves like 10ns per call to this (yeah the improvements are quite small)