Backport "[SLP] Check for PHI nodes (potentially cycles!) when checking dependencies" #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you please cherry pick with the |
…ncies When checking for dependecies for gather nodes with users with the same last instruction, cannot rely on the index order, if there is (even potential!) cycle in the graph, which may cause order not work correctly and cause compiler crash. Fixes llvm#127128 (cherry picked from commit ac217ee)
Zentrik
force-pushed
the
backport-slp-fix
branch
from
95c1b3d to
7c6f2dd
Compare
Member
Author
done in llvm#127267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports llvm@ac217ee to fix PkgEval failure, JuliaLang/julia#56130 (comment), JuliaLang/julia#56130 (comment).
Tested building and running Julia tests at https://github.com/Zentrik/llvm_julia_tester/actions/runs/13318358914/job/37197718469?pr=50 and it LGTM.