Skip to content

Cases in broadcasting columns #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cases in broadcasting columns #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions src/generic/broadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,12 +395,20 @@ function _left_colvec_banded_broadcast!(dest::AbstractMatrix, f, (A,B)::Tuple{Ab
(d_l ≥ min(l,m-1) && d_u ≥ min(u,n-1)) || throw(BandError(dest))

if d_l == B_l == l && d_u == B_u == u
for j=rowsupport(dest)
for k = max(1,j-u):min(j+min(A_l,l),m)
inbands_setindex!(dest, f(A[k], inbands_getindex(B, k, j)), k, j)
if A_l >= l
for j=rowsupport(dest)
for k = max(1,j-u):min(j+l,m)
inbands_setindex!(dest, f(A[k], inbands_getindex(B, k, j)), k, j)
end
end
for k = max(1,j-u,j+A_l+1):min(j+l,m)
inbands_setindex!(dest, f(zero(T), inbands_getindex(B, k, j)), k, j)
else
for j=rowsupport(dest)
for k = max(1,j-u):min(j+A_l,m)
inbands_setindex!(dest, f(A[k], inbands_getindex(B, k, j)), k, j)
end
for k = max(1,j-u,j+A_l+1):min(j+l,m)
inbands_setindex!(dest, f(zero(T), inbands_getindex(B, k, j)), k, j)
end
end
end
else
Expand Down Expand Up @@ -445,12 +453,20 @@ function _right_colvec_banded_broadcast!(dest::AbstractMatrix, f, (A,B)::Tuple{A
(d_l ≥ min(l,m-1) && d_u ≥ min(u,n-1)) || throw(BandError(dest))

if d_l == A_l == l && d_u == A_u == u
for j=rowsupport(dest)
for k = max(1,j-u):min(j+min(l,B_l),m)
inbands_setindex!(dest, f(inbands_getindex(A, k, j), B[k]), k, j)
if B_l >= l
for j=rowsupport(dest)
for k = max(1,j-u):min(j+l,m)
inbands_setindex!(dest, f(inbands_getindex(A, k, j), B[k]), k, j)
end
end
for k = max(1,j-u,j+B_l+1):min(j+l,m)
inbands_setindex!(dest, f(inbands_getindex(A, k, j), zero(V)), k, j)
else
for j=rowsupport(dest)
for k = max(1,j-u):min(j+B_l,m)
inbands_setindex!(dest, f(inbands_getindex(A, k, j), B[k]), k, j)
end
for k = max(1,j-u,j+B_l+1):min(j+l,m)
inbands_setindex!(dest, f(inbands_getindex(A, k, j), zero(V)), k, j)
end
end
end
else
Expand Down