Skip to content

Specify init in maximum in subblockbandwidths #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Specify init in maximum in subblockbandwidths #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BandedBlockBandedMatrix.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@
# default is to use whole block
_subblockbandwidths(A::AbstractMatrix, ::NTuple{2,OneTo{Int}}) = bandwidths(A)
function _subblockbandwidths(A::AbstractMatrix, _)
M,N = map(maximum, blocklengths.(axes(A)))
M,N = map(x -> maximum(x, init=0), blocklengths.(axes(A)))

Check warning on line 291 in src/BandedBlockBandedMatrix.jl

View check run for this annotation

Codecov / codecov/patch

src/BandedBlockBandedMatrix.jl#L291 

Added line #L291 was not covered by tests
M-1,N-1
end

Expand Down
Loading