Skip to content

Commit e4d3791

Browse files
authored
Fix Matrix(TransposeMap{CustomMap}) (#159)
1 parent f956c00 commit e4d3791

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "LinearMaps"
22
uuid = "7a12625a-238d-50fd-b39a-03d52299707e"
3-
version = "3.3.0"
3+
version = "3.3.1"
44

55
[deps]
66
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/conversion.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ function Base.Matrix{T}(A::LinearMap) where {T}
55
v = fill(zero(T), N)
66
@inbounds for i in 1:N
77
v[i] = one(T)
8-
_unsafe_mul!(view(mat, :, i), A, v)
8+
# need mul!, e.g., for TransposeMap{<:CustomMap}
9+
mul!(view(mat, :, i), A, v)
910
v[i] = zero(T)
1011
end
1112
return mat

test/linearmaps.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,4 +117,5 @@ end
117117
@test mul!(ones(3), A', x, α, β) == fill(β, 3) + fill(15α, 3)
118118
@test mul!(ones(3, 2), A', [x x], α, β) == fill(β, 3, 2) + fill(15α, 3, 2)
119119
end
120+
@test Matrix(A') == Matrix(A)'
120121
end

0 commit comments

Comments
 (0)