Skip to content

Conversation

jaakkor2
Copy link

@jaakkor2 jaakkor2 commented Jul 7, 2025

As coded here
https://github.com/JuliaLinearAlgebra/MatrixFactorizations.jl/blob/v3.0.1/src/polar.jl#L572-L573

function polar(A::AbstractMatrix{T};
                   alg::Symbol=:newton,

also tests are written with keyword alg, not algorithm.

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (6874396) to head (ec767d9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files           9        9           
  Lines        1401     1401           
=======================================
  Hits         1298     1298           
  Misses        103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant