Skip to content

Fix BLAS info for failures to be properly negative #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix BLAS info for failures to be properly negative #99

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71a98f0
Fix BLAS info for failures to be properly negative
ChrisRackauckas Sep 26, 2025
f7fec9b
Update lu.jl
ChrisRackauckas Sep 26, 2025
d517599
Update lu.jl
ChrisRackauckas Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lu.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ function lu!(A::AbstractMatrix{T}, ipiv::AbstractVector{<:Integer},
info = _generic_lufact!(A, pivot, ipiv, info)
end
((check isa Bool && check) || (check === Val(true))) && checknonsingular(info)
LU(A, ipiv, info)
LU(A, ipiv, -info)
end

@inline function recurse!(A, ::Val{Pivot}, m, n, mnmin, ipiv, info, blocksize,
Expand Down Expand Up @@ -302,7 +302,7 @@ function _generic_lufact!(A, ::Val{Pivot}, ipiv, info) where {Pivot}
A[i, k] *= Akkinv
end
elseif info == 0
info = k
info = -k
end
k == minmn && break
# Update the rest
Expand Down
Loading