Deprecate verbosity macros (not compatible w/ juliac-compiled programs) #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add convenience group keyword to withlevel to do early filtering on groups Export withlevel
oxinabox
reviewed
Oct 22, 2024
oxinabox
reviewed
Oct 22, 2024
Comment on lines
+92
to
+95
| For convenience, a `group` keyword argument can be passed which also | ||
| filters logging messages on the "group". By default, the group is the | ||
| file name of the log macro call site, but can be overridden by passing | ||
| the `_group` keyword argument to the logging macros. |
There was a problem hiding this comment.
I am not conviced thsi is better than just using
with_logger(EarlyFilteredLogger(x->x.group==:Foo) do
...
end
Maybe we should instead be adding a
filter_group_logger(group) = EarlyFilteredLogger(x->x.group==group)
if it really is too long
There was a problem hiding this comment.
It's really the convenience of having it bundled with the withlevel function. It's so onerous remembering the incantation to get the logger, set it to the new one, and then on top remember the LoggingExtras machinery to early filter. Bundling that all up into withlevel as the "one thing" I need to remember as a package dev is what makes this work really well.
Co-authored-by: Frames White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add convenience group keyword to withlevel to do early filtering on groups
Export withlevel