Fix MultilineChartContent not defined#119
Open
ldeso wants to merge 2 commits intoJuliaLogging:masterfrom
Open
Conversation
ldeso
changed the title
ldeso
force-pushed
the
fix-MultilineChartContent-not-defined
branch
from
d0609f9 to
2ad5f15
Compare
ldeso
force-pushed
the
fix-MultilineChartContent-not-defined
branch
from
9e399e2 to
19a5e6a
Compare
Contributor
Author
|
Due to the ProtoBuf update, there are actually more changes required. Marking this as draft for now. Edit: done I think! |
Contributor
Author
|
For the record, even with the changes in this pull request there is still an issue an with the custom_scalar plugin and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling the function log_custom_scalar results in an error:
This fixes the error by importing the missing undefined classes.
Those classes are defined in src/protojl/tensorboard/plugins/custom_scalar/tensorboard/layout_pb.jl.
This is similar to what was done in the file for the audio logger src/Loggers/LogAudio.jl.