-
Couldn't load subscription status.
- Fork 30
Update to new protobuf and removed workaround for hparams encoding #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
a961114
603d82b
9f2b60b
41f2cf3
c20f294
40c9822
95aa514
ea302f8
60888eb
f478df8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| name = "TensorBoardLogger" | ||
| uuid = "899adc3e-224a-11e9-021f-63837185c80f" | ||
| authors = ["Filippo Vicentini <[email protected]>"] | ||
| version = "0.1.22" | ||
| version = "0.1.23" | ||
|
|
||
| [deps] | ||
| CRC32c = "8bf52ea8-c179-5cab-976a-9e18b702a9bc" | ||
|
|
@@ -14,7 +14,7 @@ StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91" | |
| [compat] | ||
| FileIO = "1.2.3" | ||
| ImageCore = "0.8.1, 0.9" | ||
| ProtoBuf = "1.0.11" | ||
| ProtoBuf = "1.0.12" | ||
| Requires = "0.5, 1" | ||
| StatsBase = "0.27, 0.28, 0.29, 0.30, 0.31, 0.32, 0.33, 0.34" | ||
| julia = "1.6" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # Autogenerated using ProtoBuf.jl v1.0.11 on 2023-06-19T18:18:24.780 | ||
| # original file: /home/lior/.julia/dev/ProtoBuf/src/google/protobuf/wrappers.proto (proto3 syntax) | ||
| # Autogenerated using ProtoBuf.jl v1.0.11 on 2023-08-09T10:18:18.634 | ||
| # original file: proto/tensorboard/google/protobuf/wrappers.proto (proto3 syntax) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This censored path doesn't look quite right |
||
|
|
||
| import ProtoBuf as PB | ||
| using ProtoBuf: OneOf | ||
|
|
@@ -276,4 +276,4 @@ function PB._encoded_size(x::StringValue) | |
| encoded_size = 0 | ||
| !isempty(x.value) && (encoded_size += PB._encoded_size(x.value, 1)) | ||
| return encoded_size | ||
| end | ||
| end | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # Autogenerated using ProtoBuf.jl v1.0.11 on 2023-06-19T18:18:24.964 | ||
| # original file: /home/lior/TensorBoardLogger.jl/gen/proto/tensorboard/plugins/custom_scalar/layout.proto (proto3 syntax) | ||
| # Autogenerated using ProtoBuf.jl v1.0.11 on 2023-08-09T10:18:18.779 | ||
| # original file: proto/tensorboard/plugins/custom_scalar/tensorboard/layout.proto (proto3 syntax) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here it's unclear that this file came from the |
||
|
|
||
| import ProtoBuf as PB | ||
| using ProtoBuf: OneOf | ||
|
|
@@ -237,4 +237,4 @@ function PB._encoded_size(x::Layout) | |
| x.version != zero(Int32) && (encoded_size += PB._encoded_size(x.version, 1)) | ||
| !isempty(x.category) && (encoded_size += PB._encoded_size(x.category, 2)) | ||
| return encoded_size | ||
| end | ||
| end | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ module tensorboard_plugin_custom_scalar | |
|
|
||
| include("layout_pb.jl") | ||
|
|
||
| end # module tensorboard | ||
| end # module tensorboard | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,4 @@ include("../google/google.jl") | |
|
|
||
| include("hparams/hparams.jl") | ||
|
|
||
| end # module tensorboard | ||
| end # module tensorboard | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ module tensorboard_plugin_text | |
|
|
||
| include("plugin_data_pb.jl") | ||
|
|
||
| end # module tensorboard | ||
| end # module tensorboard | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this for a separate PR. This censoring is redundant and messes up file paths.
This censoring can be done with a shell script:
>>> cat file_list | xargs -I f sed -i 's|/home/lior||g' fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise the
_pb.jlfiles can be restored to their previous version with the full path