Skip to content

Fix retracts in LineSearches extension #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025
Merged

Fix retracts in LineSearches extension #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f75058
Fix two `retract!` calls, that since `ManifoldsBase`1.0 are `retract_…
kellertuer May 11, 2025
7c5347f
bump version
kellertuer May 11, 2025
17f883b
Fix Documenter version for a while.
kellertuer May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ The file was started with Version `0.4`.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.5.16] 2025-05-07

### Fixed

* fixes a bug in the `LineSearches.jl` extension, where two (old) `retract!`s were still
present; they were changed to `retact_fused!`.

## [0.5.15] 2025-05-06

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Manopt"
uuid = "0fc0a36d-df90-57f3-8f93-d78a9fc72bb5"
authors = ["Ronny Bergmann <[email protected]>"]
version = "0.5.15"
version = "0.5.16"

[deps]
ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"
Expand Down
2 changes: 1 addition & 1 deletion docs/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ BenchmarkTools = "1.3"
CSV = "0.10"
Colors = "0.12, 0.13"
DataFrames = "1"
Documenter = "1"
Documenter = "=1.10.2"
DocumenterCitations = "1"
DocumenterInterLinks = "0.3, 1"
FiniteDifferences = "0.12"
Expand Down
4 changes: 2 additions & 2 deletions ext/ManoptLineSearchesExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ function (cs::Manopt.LineSearchesStepsize)(
# perform actual line-search

function ϕ(α)
retract!(M, p_tmp, p, η, α, cs.retraction_method)
ManifoldsBase.retract_fused!(M, p_tmp, p, η, α, cs.retraction_method)
return f(M, p_tmp)
end
function dϕ(α)
retract!(M, p_tmp, p, η, α, cs.retraction_method)
ManifoldsBase.retract_fused!(M, p_tmp, p, η, α, cs.retraction_method)
get_gradient!(mp, X_tmp, p_tmp)
vector_transport_to!(M, Y_tmp, p, η, p_tmp, cs.vector_transport_method)
return real(inner(M, p_tmp, X_tmp, Y_tmp))
Expand Down
Loading