Skip to content

Derangements #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inkydragon merged 5 commits into from
May 10, 2025
Merged

Derangements #150

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa90350
Add a function to generate all derangements.
FedericoStra Dec 15, 2023
d16ccf7
Add tests for `derangements`
FedericoStra Dec 15, 2023
6897953
Add doctest for `derangements`
FedericoStra May 2, 2025
82fc13d
Fix type stability in `multiset_permutations`
FedericoStra May 10, 2025
4944526
Remove unnecessary call to `collect`
FedericoStra May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/permutations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ julia> collect(multiset_permutations([1,1,2], 3))
```
"""
function multiset_permutations(a, t::Integer)
m = unique(collect(a))
m = unique(a)
Copy link
Contributor Author

@FedericoStra FedericoStra May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call to collect is unnecessary because unique already collects the items into a new vector.

Benchmark Benchmark improves to 
julia> @benchmark multiset_permutations($a)
BenchmarkTools.Trial: 10000 samples with 27 evaluations per sample.
 Range (min … max):  930.074 ns … 160.078 μs  ┊ GC (min … max):  0.00% … 98.59%
 Time  (median):     956.333 ns               ┊ GC (median):     0.00%
 Time  (mean ± σ):     1.094 μs ±   3.083 μs  ┊ GC (mean ± σ):  10.17% ±  4.00%

  ▅█▇▅▃▁     ▁                                                  ▂
  ███████▇▆▇████▇▆▇▅▅▅▅▄▄▁▁▃▃▃▄▁▁▄▁▃▄▃▃▁▅▅▁▃▄▅▄▇▇▆▅▃▅▅▆▅▅▅▅▄▅▅▄ █
  930 ns        Histogram: log(frequency) by time       1.75 μs <

 Memory estimate: 2.16 KiB, allocs estimate: 33.

f = [sum(c == x for c in a)::Int for x in m]
Copy link
Contributor Author

@FedericoStra FedericoStra May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I also removed the square brackets to turn the comprehension into a generator expression, which is ever so slightly more efficient, as can be verified by benchmarking.

Benchmark 
julia> a = repeat(1:10, 3);

With comprehension:

julia> @benchmark multiset_permutations($a)
BenchmarkTools.Trial: 10000 samples with 10 evaluations per sample.
 Range (min … max):  1.284 μs …  1.236 ms  ┊ GC (min … max):  0.00% … 99.62%
 Time  (median):     1.350 μs              ┊ GC (median):     0.00%
 Time  (mean ± σ):   1.921 μs ± 16.533 μs  ┊ GC (mean ± σ):  12.11% ±  1.41%

  ▆█▇▄▂                   ▁   ▁▂ ▁▂▂▁▁▂▃▂▁▂▂▂▁▁▁▁▁           ▁
  █████▇▆▅▅▄▅▇▇▇▅▆▄▅▅▇▆▅▅▇██▇█████████████████████████▇▇▇▇▆▅ █
  1.28 μs      Histogram: log(frequency) by time     3.07 μs <

 Memory estimate: 3.39 KiB, allocs estimate: 55.

With generator expression:

julia> @benchmark multiset_permutations($a)
BenchmarkTools.Trial: 10000 samples with 22 evaluations per sample.
 Range (min … max):  943.545 ns … 462.770 μs  ┊ GC (min … max):  0.00% … 99.37%
 Time  (median):     976.227 ns               ┊ GC (median):     0.00%
 Time  (mean ± σ):     1.251 μs ±   5.907 μs  ┊ GC (mean ± σ):  13.38% ±  3.54%

  ▇█▄▁   ▁              ▁ ▂▂▁▂▁▂▁▁▁                             ▂
  ████▇▇████▇▆▅▄▃▁▁▁▁▄▆▆█████████████▇▇▆▆▆▄▄▄▄▁▄▄▄▃▅▄▃▃▁▄▄▁▃▁▁▅ █
  944 ns        Histogram: log(frequency) by time       2.54 μs <

 Memory estimate: 2.45 KiB, allocs estimate: 35.

multiset_permutations(m, f, t)
end
Expand Down
Loading