fix issue #58; set initial n to min. points#108
Open
manuelbb-upb wants to merge 2 commits intoJuliaMath:masterfrom
Open
fix issue #58; set initial n to min. points#108manuelbb-upb wants to merge 2 commits intoJuliaMath:masterfrom
n to min. points#108manuelbb-upb wants to merge 2 commits intoJuliaMath:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #58
There is a bug in https://www.netlib.org/dierckx/fpclos.f
Inspecting the goto-statements, we see that
nis never properly initialized in cases>0.In this case, it is assigned only after
if(n.ge.nest) go to 620(triggering an error code1).On our side, we can initialize the reference to
nbefore calling the Fortran subroutine, this appears to fix the issue.