Skip to content

Fix (style?) issues flagged by JETLS #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannys4 merged 2 commits into from
Feb 27, 2026
Merged

Fix (style?) issues flagged by JETLS #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe6fcc6
fix (style?) issues flagged by jetls
wheeheee Feb 27, 2026
c6f3f55
rename
wheeheee Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/algos.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,17 @@ function fft_composite!(out::AbstractVector{T}, in::AbstractVector{U}, start_out
tmp = g.workspace[idx]

if Rt === BLUESTEIN
R_scratch = prealloc_blue(N2, d, T)
R_bluestein_scratchspace = prealloc_blue(N2, d, T)
end
for j1 in 0:N1-1
wk2 = wj1
R_start_in = start_in + j1 * s_in
R_start_out = 1 + N2 * j1

if Rt === BLUESTEIN
if @isdefined R_bluestein_scratchspace
R_s_in = right.s_in
R_s_out = right.s_out
fft_bluestein!(tmp, in, d, N2, R_start_out, R_s_out, R_start_in, R_s_in, R_scratch)
fft_bluestein!(tmp, in, d, N2, R_start_out, R_s_out, R_start_in, R_s_in, R_bluestein_scratchspace)
else
fft!(tmp, in, R_start_out, R_start_in, d, Rt, g, right_idx)
end
Expand All @@ -97,15 +97,15 @@ function fft_composite!(out::AbstractVector{T}, in::AbstractVector{U}, start_out
end

if Lt === BLUESTEIN
L_scratch = prealloc_blue(N1, d, T)
L_bluestein_scratchspace = prealloc_blue(N1, d, T)
end
for k2 in 0:N2-1
L_start_out = start_out + k2 * s_out
L_start_in = 1 + k2
if Lt === BLUESTEIN
if @isdefined L_bluestein_scratchspace
L_s_in = left.s_in
L_s_out = left.s_out
fft_bluestein!(out, tmp, d, N1, L_start_out, L_s_out, L_start_in, L_s_in, L_scratch)
fft_bluestein!(out, tmp, d, N1, L_start_out, L_s_out, L_start_in, L_s_in, L_bluestein_scratchspace)
else
fft!(out, tmp, L_start_out, L_start_in, d, Lt, g, left_idx)
end
Expand Down
6 changes: 3 additions & 3 deletions src/plan.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ AbstractFFTs.plan_fft(x::AbstractArray{T,N}, region::R; kwargs...) where {T<:Com
AbstractFFTs.plan_bfft(x::AbstractArray{T,N}, region::R; kwargs...) where {T<:Complex,N,R} =
_plan_fft(x, region, FFT_BACKWARD; kwargs...)

function _plan_fft(x::AbstractArray{T,N}, region::R, dir::Direction; BLUESTEIN_CUTOFF=DEFAULT_BLUESTEIN_CUTOFF, kwargs...) where {T<:Complex,N,R}
function _plan_fft(x::AbstractArray{T,N}, region::R, dir::Direction; BLUESTEIN_CUTOFF=DEFAULT_BLUESTEIN_CUTOFF, _kwargs...) where {T<:Complex,N,R}
FFTN = length(region)
if FFTN == 1
R1 = Int(region[])
Expand All @@ -74,7 +74,7 @@ function _plan_fft(x::AbstractArray{T,N}, region::R, dir::Direction; BLUESTEIN_C
end
end

function AbstractFFTs.plan_rfft(x::AbstractArray{T,N}, region::R; BLUESTEIN_CUTOFF=DEFAULT_BLUESTEIN_CUTOFF, kwargs...) where {T<:Real,N,R}
function AbstractFFTs.plan_rfft(x::AbstractArray{T,N}, region::R; BLUESTEIN_CUTOFF=DEFAULT_BLUESTEIN_CUTOFF, _kwargs...) where {T<:Real,N,R}
FFTN = length(region)
if FFTN == 1
R1 = Int(region[])
Expand All @@ -97,7 +97,7 @@ function AbstractFFTs.plan_rfft(x::AbstractArray{T,N}, region::R; BLUESTEIN_CUTO
end
end

function AbstractFFTs.plan_brfft(x::AbstractArray{T,N}, len, region::R; BLUESTEIN_CUTOFF=DEFAULT_BLUESTEIN_CUTOFF, kwargs...) where {T,N,R}
function AbstractFFTs.plan_brfft(x::AbstractArray{T,N}, len, region::R; BLUESTEIN_CUTOFF=DEFAULT_BLUESTEIN_CUTOFF, _kwargs...) where {T,N,R}
FFTN = length(region)
if FFTN == 1
# For even length problems, we solve the real problem with
Expand Down
Loading