Skip to content

Require Julia v1.10 (LTS) #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Require Julia v1.10 (LTS) #312

wants to merge 11 commits into from

Conversation

dlfivefifty
Copy link
Member

The motivation for this change would be to allow adding extensions without adding unnecessary dependencies for users on pre-v1.10.

In particular, this makes it easier to finish #311

See also JuliaMath/AbstractFFTs.jl#140

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.51%. Comparing base (7b20cb5) to head (23804f7).

Files with missing lines Patch % Lines
src/fft.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   71.50%   73.51%   +2.01%     
==========================================
  Files           5        5              
  Lines         544      540       -4     
==========================================
+ Hits          389      397       +8     
+ Misses        155      143      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano
Copy link
Member

I'm not sure this is strictly necessary for adding an extension: the extension would work only in Julia v1.9+, but can exist, without working also in previous releases. Requiring Julia v1.10 nowadays is a good idea regardless though.

@vtjnash
Copy link
Contributor

vtjnash commented Aug 12, 2025

Same for #318. I could add v1.6 support to that, but it seems quite unnecessary to assume that would be useful at this point

@stevengj
Copy link
Member

stevengj commented Aug 12, 2025

Seems fine to me at this point to require 1.10.

@@ -27,7 +27,7 @@ jobs:
- 'fftw'
- 'mkl'
version:
- '1.6'
- 'min'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we could do this. So this automatically tests on the minimum-supported version from Project.toml?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 👍

@@ -13,8 +13,8 @@ Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
[compat]
AbstractFFTs = "1.5"
FFTW_jll = "3.3.9"
LinearAlgebra = "<0.0.1, 1"
LinearAlgebra = "1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958#update-november-9th-2023-2 still the recommended approach? Then this should be changed back to

Suggested change
LinearAlgebra = "1"
LinearAlgebra = "<0.0.1, 1"

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR probably should clean up a few unnecessary VERSION checks as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants