-
Notifications
You must be signed in to change notification settings - Fork 53
Require Julia v1.10 (LTS) #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 71.50% 73.51% +2.01%
==========================================
Files 5 5
Lines 544 540 -4
==========================================
+ Hits 389 397 +8
+ Misses 155 143 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm not sure this is strictly necessary for adding an extension: the extension would work only in Julia v1.9+, but can exist, without working also in previous releases. Requiring Julia v1.10 nowadays is a good idea regardless though. |
Co-authored-by: Mosè Giordano <[email protected]>
Same for #318. I could add v1.6 support to that, but it seems quite unnecessary to assume that would be useful at this point |
Seems fine to me at this point to require 1.10. |
@@ -27,7 +27,7 @@ jobs: | |||
- 'fftw' | |||
- 'mkl' | |||
version: | |||
- '1.6' | |||
- 'min' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize we could do this. So this automatically tests on the minimum-supported version from Project.toml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes 👍
@@ -13,8 +13,8 @@ Reexport = "189a3867-3050-52da-a836-e630ba90ab69" | |||
[compat] | |||
AbstractFFTs = "1.5" | |||
FFTW_jll = "3.3.9" | |||
LinearAlgebra = "<0.0.1, 1" | |||
LinearAlgebra = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958#update-november-9th-2023-2 still the recommended approach? Then this should be changed back to
LinearAlgebra = "1" | |
LinearAlgebra = "<0.0.1, 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR probably should clean up a few unnecessary VERSION
checks as well.
The motivation for this change would be to allow adding extensions without adding unnecessary dependencies for users on pre-v1.10.
In particular, this makes it easier to finish #311
See also JuliaMath/AbstractFFTs.jl#140