Skip to content

Make indexing by non-integers an error #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make indexing by non-integers an error #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5edf6a
Make indexing by non-integers an error
mkitti Sep 25, 2025
d9b6b3e
Add tests to check against StackOverflow
mkitti Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/deprecations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# Removed with 0.16, indexing via non-integers
getindex(itp::AbstractInterpolation{T,N}, i::Vararg{Number,N}) where {T,N} =
error("Indexing an AbstractInterpolation by non-integers is no longer supported in Interpolations.jl since v0.16. Use the function calling interface instead: `itp(i...)`.")
getindex(itp::AbstractInterpolation{T,N}, i::Vararg{ExpandedIndexTypes,N}) where {T,N} =
error("Indexing an AbstractInterpolation by non-integers is no longer supported in Interpolations.jl since v0.16. Use the function calling interface instead: `itp(i...)`.")

for T in (:Throw, :Flat, :Line, :Free, :Periodic, :Reflect, :InPlace, :InPlaceQ)
@eval begin
Expand Down
6 changes: 6 additions & 0 deletions test/issues/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,4 +177,10 @@ using Interpolations, Test, ForwardDiff
t = -3.0:0.01:3.0
@test itp_cdf.(t) isa Vector{Float64}
end
@testset "issue 630" begin
itp = interpolate(ones(100,100), BSpline(Linear()));
# Indexing by non-integers should not result in a StackOverflow due to `Base.to_index(::AbstractInterpolation, x::Number) = x`
@test_throws "Indexing an AbstractInterpolation by non-integers is no longer supported" itp[2.2, 33.3]
@test_throws "Indexing an AbstractInterpolation by non-integers is no longer supported" itp[2.2, 2.0:5.0]
end
end
Loading