Skip to content

Test min, lts and 1 in CI #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Test min, lts and 1 in CI #478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c396ac
Test `min`, `lts` and `1` in CI
devmotion Oct 17, 2024
f1acc19
Improve job name
devmotion Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,37 +8,33 @@ on:

jobs:
test:
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }}
name: Julia ${{ matrix.version }} - ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
version:
- '1.6'
- 'min'
- 'lts'
- '1'
os:
- ubuntu-latest
- macOS-latest
- windows-latest
arch:
- x64
exclude:
- os: macOS-latest # Apple Silicon
version: 'min'
include:
- os: macOS-13
arch: x64
version: 1
- os: macOS-latest
arch: aarch64
version: 1

- os: macOS-13 # Intel
version: 'min'
Copy link
Member

@ararslan ararslan Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 'min'
version: 'min'
- os: ubuntu-latest
version: 'nightly'

Might as well keep one nightly test, IMO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed in #477 but I'm fine with keeping a test for unreleased Julia versions. Maybe

Suggested change
version: 'min'
version: 'min'
- os: ubuntu-latest
version: 'pre'

would give a bit more stable and possibly more relevant test results?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this for a follow-up PR in case we want to test pre or nightly again.

steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: julia-actions/cache@v2
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
continue-on-error: ${{ matrix.version == 'nightly' }}
- uses: julia-actions/julia-processcoverage@v1
continue-on-error: true
- uses: codecov/codecov-action@v4
Expand Down
Loading