Skip to content

Conversation

devmotion
Copy link
Member

Fixes #475.

The docstring of floatmax only mentions and shows its application to types, not to values. Hence IMO as in other places in SpecialFunctions we should apply floatmax to types, not to values.

I didn't want to add a test with ForwardDiff since this would create a dependency cycle - ForwardDiff depends on SpecialFunctions, so e.g. breaking releases of SpecialFunctions could not be tested before a new version of ForwardDiff is released. Maybe a test should be added in ForwardDiff once the issue is fixed?

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.11%. Comparing base (f8fd782) to head (7a1d2d6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          14       14           
  Lines        2905     2905           
=======================================
  Hits         2734     2734           
  Misses        171      171           
Flag Coverage Δ
unittests 94.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mancellin
Copy link

Thanks @devmotion for taking care of it

@devmotion devmotion merged commit 738435a into master Apr 14, 2025
12 checks passed
@devmotion devmotion deleted the dw/floatmax branch April 14, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of expint with ForwardDiff

3 participants