Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #475.
The docstring of
floatmax
only mentions and shows its application to types, not to values. Hence IMO as in other places in SpecialFunctions we should applyfloatmax
to types, not to values.I didn't want to add a test with ForwardDiff since this would create a dependency cycle - ForwardDiff depends on SpecialFunctions, so e.g. breaking releases of SpecialFunctions could not be tested before a new version of ForwardDiff is released. Maybe a test should be added in ForwardDiff once the issue is fixed?