-
Notifications
You must be signed in to change notification settings - Fork 6
tweaks to figures, moved tidierplots figures to AoG #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There is just one more plot left to move from R to Julia |
|
@palday can we get this merged? |
|
this will get rid of most if not all R dependency |
| execute: | ||
| cache: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we should be able to set this at the project level and not need to specify it in every file
[noblock]
|
a little bit of history here: we were actually working on moving in the other direction, i.e. porting all the AoG plots to Tidier. There were two reasons for this:
I don't have a terribly strong preference either way, but I don't want us to be bouncing back and forth as TiderPlots and AoG one-up each other. I think porting R-based figures to Julia is an obvious improvement -- could you split that out into a separate PR that I'll review and then we can leave the bigger Tidier vs AoG discussion for this PR? Also, I haven't checked the render yet, but make sure the lattice plot in Julia matches the aspect ratio in R. @dmbates has noted that the human eye is very good at pickup deviations from a 45 degree diagonal and so it's good to have an aspect ratio that makes that diagonal meaningful. (I'm doing a horrible job explaining this.) |
|
Your local copy has that data cached, so it doesn't have to re-download it, but the CI runner needs to pull it down. It looks like the certificate expired at |
I see. any idea how i can fix it? |
|
Just have to wait for the site owner to fix their certificate. Hopefully they notice soon... |
longitudinal.qmd(Itercept) -> (Intercept)largescaleobservedAlgebraOfGraphicsTidierPlotsas a dependency, which will allow us to setalphafor histograms inintro.qmd(see below)RCallas a dependency (which should get rid of Conda)intro.qmd: