AtomsBase v0.5 update #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cortner this is ready for merge. After tagging new version, we can continue to update AtomsCalculatorsUtilities and EmpiricalPotentials to ABv0.5 |
Member
|
thank you. I'll take care of that now. |
Member
|
Since this changes the compatibility (rather than just expanding it), would this be best considered a breaking change? |
Contributor
Author
|
Nothing in the user interface has changes, so any package using this works as is. The only change is that AB is not backwards compatible, but that is not issue for packages using this package. |
Member
|
ok, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to AB v0.5 that is needed for AtomsCalculatorsUtilities.jl and EmpiricalPotentials.jl JuliaMolSim/EmpiricalPotentials.jl#30.
There is also an update to testing part to swap to use AtomsBuilder.jl instead of using ASEconvert.jl.