Julia Formatter, removed zeroT and replaced it with zero(T), changed x == nothing to isnothing(x) and added check if phi_x is finite in Backtracking #179
Open
theplatters wants to merge 3 commits intoJuliaNLSolvers:masterfrom
Conversation
…= nothing to isnothing(x). Added check if value is infinit in Backtracking
Author
|
Are the failed tests a result of my code? They passed locally, and the error message seems like a dependency error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am doing a few readability improvememts of this package and will try to refactor StrongWolfe and work off the Todos that are still in the code. This is the first step.