Require Julia 1.10 and remove Parameters#188
Closed
devmotion wants to merge 2 commits intoJuliaNLSolvers:masterfrom
Closed
Require Julia 1.10 and remove Parameters#188devmotion wants to merge 2 commits intoJuliaNLSolvers:masterfrom
devmotion wants to merge 2 commits intoJuliaNLSolvers:masterfrom
Conversation
Contributor
Author
|
@pkofod I haven't contributed to this repo yet, could you trigger the CI workflow in this PR? |
Member
|
#189 has these changes already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters.@unpackis not needed on Julia >= 1.7 as one can just use the native(; ...) = ...syntax; similarly one can use@kwdefinstead ofParameters.@with_kw.In fact,
@unpack(which was factored out toUnPackat some point) createsValdispatches for the property accesses which at some point caused compilation time issues in OrdinaryDiffEq; since that was prior to Julia 1.7, we replaced it withSimpleUnPack.@unpackfor a while: https://github.com/devmotion/SimpleUnPack.jlCurrently, the package supports Julia 1.6, so to be able to use
(; ...) = ...and@kwdefI updated the Julia compat entry to 1.10 and also updated CI.