Adding time limit to levenberg_marquardt.jl#204
Adding time limit to levenberg_marquardt.jl#204Gkreindler wants to merge 5 commits intoJuliaNLSolvers:masterfrom
Conversation
|
Hello, any change someone might be able to review this? I think it is very simple, and I would like to use this feature in a package that I am working on. |
I'm sorry for not reviewing, I appreciate the effort! I changed your initial value from -1 to The other comment I have is that typically you'd be required to add a test. Sometimes it's a bit hard to come up with a test. In this case you could maybe use a model that would otherwise converge fine, but that has |
This small edit allows levenberg_marquardt() to exit if a specified time limit is exceeded.
This is my first ever pull request, so any tips or pointers to best practices are welcome!