Open
Conversation
This package is almost ready to be used straight up with StaticArrays. Most variables are already written in a general way, there are just two blockers: The preallocated buffers `JJ` and `n_buffer`, aswell as the LMResults type. This commit fixes that, and almost allows usage of StaticArrays. However, there's still JuliaDiff/DiffResults.jl#25, but that can be currently overcome by two typedefs.
Member
|
Is this still waiting for the AD-issue? You can maybe add a test that has hand-written Jacobins or finitediff? (if that works..) |
Contributor
|
Any update here? Would really love to see this merged! |
Member
|
Waiting for feedback from the PR starter :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is almost ready to be used straight up with StaticArrays.
Most variables are already written in a general way, there are just two
blockers:
The preallocated buffers
JJandn_buffer, aswell as the LMResultstype.
This PR fixes that, and almost allows usage of StaticArrays.
However, there's still
JuliaDiff/DiffResults.jl#25, but that can be
currently overcome by two function definitions shows in the PR.