Conversation
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1186 +/- ##
==========================================
+ Coverage 85.73% 85.79% +0.06%
==========================================
Files 46 45 -1
Lines 3604 3577 -27
==========================================
- Hits 3090 3069 -21
+ Misses 514 508 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devmotion
reviewed
Oct 31, 2025
| F::Fminbox = Fminbox(), | ||
| options::Options = Options(); | ||
| inplace::Bool=true, | ||
| autodiff = :finite, |
Contributor
There was a problem hiding this comment.
Maybe a good opportunity to switch to ADTypes instead of Symbols?
Member
Author
There was a problem hiding this comment.
good point to make the switch for good in v2 not that we are breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may re-instate inplace and autodiff for the function input api