Skip to content

Fix unnecessary allocations in maximization due to insufficient broadcasting#1189

Merged
pkofod merged 3 commits intoJuliaNLSolvers:masterfrom
devmotion:patch-1
Nov 2, 2025
Merged

Fix unnecessary allocations in maximization due to insufficient broadcasting#1189
pkofod merged 3 commits intoJuliaNLSolvers:masterfrom
devmotion:patch-1

Conversation

@devmotion
Copy link
Contributor

Fixes #1188.

Would be good to add tests.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.86%. Comparing base (22be384) to head (8549fe6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
+ Coverage   85.79%   85.86%   +0.06%     
==========================================
  Files          45       45              
  Lines        3577     3586       +9     
==========================================
+ Hits         3069     3079      +10     
+ Misses        508      507       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkofod
Copy link
Member

pkofod commented Nov 1, 2025

tests

do you want to test the allocations?

I also don't know why the benchmarks failed to run here, they also failed in the iterator PR

@devmotion
Copy link
Contributor Author

I also don't know why the benchmarks failed to run here, they also failed in the iterator PR

Probably because those are PRs from forks?

@pkofod
Copy link
Member

pkofod commented Nov 1, 2025

ah yours is also from a fork, of course that must be it

@pkofod
Copy link
Member

pkofod commented Nov 1, 2025

that seems suboptimal :)

@pkofod pkofod merged commit 80e498b into JuliaNLSolvers:master Nov 2, 2025
12 of 13 checks passed
@devmotion devmotion deleted the patch-1 branch November 2, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary allocations in maximization due to insufficient broadcasting

2 participants