Fix unnecessary allocations in maximization due to insufficient broadcasting#1189
Merged
pkofod merged 3 commits intoJuliaNLSolvers:masterfrom Nov 2, 2025
Merged
Fix unnecessary allocations in maximization due to insufficient broadcasting#1189pkofod merged 3 commits intoJuliaNLSolvers:masterfrom
pkofod merged 3 commits intoJuliaNLSolvers:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
+ Coverage 85.79% 85.86% +0.06%
==========================================
Files 45 45
Lines 3577 3586 +9
==========================================
+ Hits 3069 3079 +10
+ Misses 508 507 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
do you want to test the allocations? I also don't know why the benchmarks failed to run here, they also failed in the iterator PR |
Contributor
Author
Probably because those are PRs from forks? |
Member
|
ah yours is also from a fork, of course that must be it |
Member
|
that seems suboptimal :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1188.
Would be good to add tests.