Update CI: Test min + LTS and test macOS with native binaries #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the tests that fail are quite sensitive / unstable |
|
The failing macOS test uses the native aarch64 binaries in this PR but currently on master runs with Rosetta emulation. |
|
I can make a commit to adjust the tests accordingly |
devmotion
commented
Nov 2, 2025
.github/workflows/CI.yml
Outdated
| - "min" | ||
| - "lts" | ||
| - "1" | ||
| - "pre" |
There was a problem hiding this comment.
It's a bit questionable whether to always run tests on "pre" - when there's no new prerelease available (e.g. for 1.13), then tests will be identical to "1".
There was a problem hiding this comment.
I removed it in a4c4adc
That would be great, I'm not familiar with that part of Optim yet. |
Benchmark Results (Julia vlts)Time benchmarks
Memory benchmarks
A plot of the benchmark results has been uploaded as an artifact at . |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
+ Coverage 87.59% 87.85% +0.25%
==========================================
Files 45 45
Lines 3515 3515
==========================================
+ Hits 3079 3088 +9
+ Misses 436 427 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.