Skip to content

Stop overloading Base.minimum and Base.maximum#1205

Merged
pkofod merged 1 commit intoJuliaNLSolvers:masterfrom
devmotion:dmw/minimum_maximum
Nov 13, 2025
Merged

Stop overloading Base.minimum and Base.maximum#1205
pkofod merged 1 commit intoJuliaNLSolvers:masterfrom
devmotion:dmw/minimum_maximum

Conversation

@devmotion
Copy link
Contributor

Fixes #1202.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Benchmark Results (Julia vlts)

Time benchmarks
master 874fead... master / 874fead...
multivariate/solvers/first_order/AdaMax 0.543 ± 0.0092 ms 0.544 ± 0.0095 ms 0.999 ± 0.024
multivariate/solvers/first_order/Adam 0.544 ± 0.0093 ms 0.543 ± 0.0096 ms 1 ± 0.025
multivariate/solvers/first_order/BFGS 0.26 ± 0.0084 ms 0.261 ± 0.0082 ms 0.996 ± 0.045
multivariate/solvers/first_order/ConjugateGradient 0.174 ± 0.0034 ms 0.174 ± 0.0027 ms 0.999 ± 0.025
multivariate/solvers/first_order/GradientDescent 1.54 ± 0.014 ms 1.55 ± 0.013 ms 0.993 ± 0.012
multivariate/solvers/first_order/LBFGS 0.232 ± 0.0073 ms 0.232 ± 0.0078 ms 1 ± 0.046
multivariate/solvers/first_order/MomentumGradientDescent 2.16 ± 0.017 ms 2.17 ± 0.017 ms 0.995 ± 0.011
multivariate/solvers/first_order/NGMRES 0.43 ± 0.011 ms 0.429 ± 0.011 ms 1 ± 0.036
time_to_load 0.421 ± 0.0064 s 0.428 ± 0.014 s 0.983 ± 0.034
Memory benchmarks
master 874fead... master / 874fead...
multivariate/solvers/first_order/AdaMax 0.34 k allocs: 7.16 kB 0.34 k allocs: 7.16 kB 1
multivariate/solvers/first_order/Adam 0.34 k allocs: 7.16 kB 0.34 k allocs: 7.16 kB 1
multivariate/solvers/first_order/BFGS 0.336 k allocs: 15 kB 0.336 k allocs: 15 kB 1
multivariate/solvers/first_order/ConjugateGradient 0.332 k allocs: 13.5 kB 0.332 k allocs: 13.5 kB 1
multivariate/solvers/first_order/GradientDescent 1.89 k allocs: 0.0713 MB 1.89 k allocs: 0.0713 MB 1
multivariate/solvers/first_order/LBFGS 0.317 k allocs: 14.2 kB 0.317 k allocs: 14.2 kB 1
multivariate/solvers/first_order/MomentumGradientDescent 2.24 k allocs: 0.077 MB 2.24 k allocs: 0.077 MB 1
multivariate/solvers/first_order/NGMRES 1.51 k allocs: 0.117 MB 1.49 k allocs: 0.115 MB 1.02
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

A plot of the benchmark results has been uploaded as an artifact at .

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.56%. Comparing base (b367149) to head (874fead).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/multivariate/solvers/constrained/samin.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1205   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          45       45           
  Lines        3514     3514           
=======================================
  Hits         3077     3077           
  Misses        437      437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devmotion devmotion marked this pull request as ready for review November 11, 2025 17:30
@pkofod pkofod merged commit d41f62c into JuliaNLSolvers:master Nov 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minimum and maximum should not extend Base.minimum and Base.maximum

2 participants