Fix bounds errors in default x_abschange and x_relchange
#1222
+45
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that currently the default
x_abschangeandx_relchangeassume that the state is non-empty when running parameter estimation tests with an artificial example without any parameters. Clearly, that case is not useful in practice but nevertheless I think it would be good to fix the current unsafe behaviour and use the opportunity to simplify the existing code.One consideration in this PR is whether to use
StatsBase.Linfdistor whether only to copy this arguably very simple function. Given that StatsBase is not needed in this package otherwise (see #1221), I opted for copying and adapting the implementation.