Skip to content

Conversation

@pkofod
Copy link
Member

@pkofod pkofod commented Dec 21, 2025

…l_state to initial_x in the user-facing API and export initial_state.

Fixes #962

…l_state to initial_x in the user-facing API and export initial_state.
@github-actions
Copy link
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master c1faa74... master / c1faa74...
multivariate/solvers/first_order/AdaMax 0.544 ± 0.0095 ms 0.542 ± 0.0095 ms 1 ± 0.025
multivariate/solvers/first_order/Adam 0.544 ± 0.0092 ms 0.54 ± 0.0093 ms 1.01 ± 0.024
multivariate/solvers/first_order/BFGS 0.26 ± 0.0086 ms 0.262 ± 0.0087 ms 0.992 ± 0.046
multivariate/solvers/first_order/ConjugateGradient 0.18 ± 0.0032 ms 0.18 ± 0.0033 ms 0.998 ± 0.026
multivariate/solvers/first_order/GradientDescent 1.53 ± 0.012 ms 1.55 ± 0.012 ms 0.988 ± 0.011
multivariate/solvers/first_order/LBFGS 0.231 ± 0.0071 ms 0.231 ± 0.008 ms 0.998 ± 0.046
multivariate/solvers/first_order/MomentumGradientDescent 2.15 ± 0.015 ms 2.17 ± 0.015 ms 0.991 ± 0.0098
multivariate/solvers/first_order/NGMRES 0.429 ± 0.011 ms 0.424 ± 0.011 ms 1.01 ± 0.036
time_to_load 0.373 ± 0.0029 s 0.379 ± 0.0046 s 0.984 ± 0.014
Memory benchmarks
master c1faa74... master / c1faa74...
multivariate/solvers/first_order/AdaMax 0.34 k allocs: 7.19 kB 0.34 k allocs: 7.19 kB 1
multivariate/solvers/first_order/Adam 0.34 k allocs: 7.19 kB 0.34 k allocs: 7.19 kB 1
multivariate/solvers/first_order/BFGS 0.336 k allocs: 15 kB 0.336 k allocs: 15 kB 1
multivariate/solvers/first_order/ConjugateGradient 0.338 k allocs: 13.6 kB 0.338 k allocs: 13.6 kB 1
multivariate/solvers/first_order/GradientDescent 1.89 k allocs: 0.0713 MB 1.89 k allocs: 0.0713 MB 1
multivariate/solvers/first_order/LBFGS 0.317 k allocs: 14.2 kB 0.317 k allocs: 14.2 kB 1
multivariate/solvers/first_order/MomentumGradientDescent 2.24 k allocs: 0.077 MB 2.24 k allocs: 0.077 MB 1
multivariate/solvers/first_order/NGMRES 1.41 k allocs: 0.112 MB 1.41 k allocs: 0.112 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

A plot of the benchmark results has been uploaded as an artifact at .

@github-actions
Copy link
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master 3497f42... master / 3497f42...
multivariate/solvers/first_order/AdaMax 0.549 ± 0.0075 ms 0.545 ± 0.0075 ms 1.01 ± 0.019
multivariate/solvers/first_order/Adam 0.543 ± 0.0082 ms 0.543 ± 0.0072 ms 0.999 ± 0.02
multivariate/solvers/first_order/BFGS 0.206 ± 0.0053 ms 0.206 ± 0.0054 ms 1 ± 0.036
multivariate/solvers/first_order/ConjugateGradient 0.0536 ± 0.00082 ms 0.0537 ± 0.00075 ms 0.999 ± 0.021
multivariate/solvers/first_order/GradientDescent 1.54 ± 0.016 ms 1.54 ± 0.015 ms 1 ± 0.014
multivariate/solvers/first_order/LBFGS 0.202 ± 0.0052 ms 0.202 ± 0.0052 ms 1 ± 0.036
multivariate/solvers/first_order/MomentumGradientDescent 2.25 ± 0.03 ms 2.25 ± 0.029 ms 1 ± 0.019
multivariate/solvers/first_order/NGMRES 0.515 ± 0.0088 ms 0.507 ± 0.0086 ms 1.02 ± 0.024
time_to_load 0.401 ± 0.0029 s 0.4 ± 0.0033 s 1 ± 0.011
Memory benchmarks
master 3497f42... master / 3497f42...
multivariate/solvers/first_order/AdaMax 0.356 k allocs: 7.12 kB 0.356 k allocs: 7.12 kB 1
multivariate/solvers/first_order/Adam 0.356 k allocs: 7.12 kB 0.356 k allocs: 7.12 kB 1
multivariate/solvers/first_order/BFGS 0.306 k allocs: 10.9 kB 0.306 k allocs: 10.9 kB 1
multivariate/solvers/first_order/ConjugateGradient 0.121 k allocs: 4.83 kB 0.121 k allocs: 4.83 kB 1
multivariate/solvers/first_order/GradientDescent 2.15 k allocs: 0.066 MB 2.15 k allocs: 0.066 MB 1
multivariate/solvers/first_order/LBFGS 0.349 k allocs: 12.9 kB 0.349 k allocs: 12.9 kB 1
multivariate/solvers/first_order/MomentumGradientDescent 2.55 k allocs: 0.0747 MB 2.55 k allocs: 0.0747 MB 1
multivariate/solvers/first_order/NGMRES 2.64 k allocs: 0.127 MB 2.64 k allocs: 0.127 MB 1
time_to_load 0.145 k allocs: 11 kB 0.145 k allocs: 11 kB 1

A plot of the benchmark results has been uploaded as an artifact at .

@codecov
Copy link

codecov bot commented Dec 21, 2025

Codecov Report

❌ Patch coverage is 88.48921% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.82%. Comparing base (7934f7b) to head (3497f42).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/multivariate/solvers/constrained/fminbox.jl 47.36% 10 Missing ⚠️
src/multivariate/optimize/interface.jl 79.16% 5 Missing ⚠️
src/multivariate/solvers/first_order/bfgs.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1226   +/-   ##
=======================================
  Coverage   86.82%   86.82%           
=======================================
  Files          44       44           
  Lines        3552     3552           
=======================================
  Hits         3084     3084           
  Misses        468      468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkofod pkofod merged commit 9483bd8 into master Jan 6, 2026
22 of 23 checks passed
return (x[1]-2)^2 + (x[2]-3)^2
end

initial_x = [0.0, 0.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly confusing to use the same name as for the API function here. At least it confused me initially 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No API docs for the callback arguments

3 participants