Adapt to Flux.jl > v0.13 #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This fixes the README example and passes double DQN and dueling DQN tests, but some other tests are not passing. Maybe someone more familiar with the codebase could help. |
Member
|
Made these changes and a few others in #76. An update based on how Flux changed the recurrent network layers will be needed to use Flux 0.15 or 0.16. I do not use this package and defer to @MaximeBouton, @zsunberg, or others for insights on the needed changes. |
Member
|
See #76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Flux release notes,
https://github.com/FluxML/Flux.jl/blob/cb9bb307b30b9111617e5b28ea1c5398ef3693f3/NEWS.md
version 0.13 replaced
loadparam!byloadmodel, and version 0.14.13 deprecated the macro@functorin favor ofFlux.@layer. This pull request adapts the code for these two changes.