Skip to content

Add convert_s function #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zsunberg merged 9 commits into from
May 31, 2025
Merged

Add convert_s function #18

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2b8c7d4
Update LaserTag.jl
yangyou95 Dec 13, 2022
c18fa55
Update LaserTag.jl
yangyou95 Dec 20, 2022
da28f02
update LaserTag convert_s and test functions
yangyou95 Jan 17, 2023
419773a
Merge branch 'JuliaPOMDP:master' into master
yangyou95 May 30, 2025
9dea048
update convert_s function and add tests
yangyou95 May 30, 2025
5738c7b
Removed extra comments
zsunberg May 30, 2025
b4c311e
Update runtests.jl
zsunberg May 30, 2025
80307b4
Merge branch 'master' into master
zsunberg May 31, 2025
26e69f0
add StaticArrays to test imports
zsunberg May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/LaserTag.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,11 @@ function POMDPs.reward(p::LaserTagPOMDP, s::LTState, a::Int, sp::LTState)
end
end

# add a function to transform a LTState to a vector
function POMDPs.convert_s(T::Type{<:AbstractArray}, s::LTState, p::LaserTagPOMDP)
return convert(T, vcat(s.robot, s.opponent, [s.terminal]))
Copy link
Member

@zsunberg zsunberg Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return convert(T, vcat(s.robot, s.opponent, [s.terminal]))
return convert(T, vcat(s.robot, s.opponent, s.terminal))

I don't think you need to create a vector with s.terminal in it. That will cause an additional allocation.

(additionally, I think vcat itself might cause an allocation, which is disappointing. You might be able to eliminate all allocations with StaticArrays, but that might take a bit of learning. There are many tools to track allocations including BenchmarkTools.@btime

Copy link
Contributor Author

@yangyou95 yangyou95 Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info!

end

POMDPs.isterminal(p::LaserTagPOMDP, s::LTState) = s.terminal
POMDPs.discount(p::LaserTagPOMDP) = p.discount

Expand Down