Make rename_wrapper_prefixes work for HostToolsToolchain
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to fix the following error:
```
ERROR: MethodError: no method matching rename_wrapper_prefixes(::String, ::Set{Symbol}, ::BinaryBuilderToolchains.HostToolsToolchain)
The function `rename_wrapper_prefixes` exists, but no method is defined for this combination of argument types.
Closest candidates are:
rename_wrapper_prefixes(::String, ::Set{Symbol}, ::BinaryBuilder2.PlatformlessWrapper{T}) where T
@ BinaryBuilder2 ~/.julia/packages/BinaryBuilder2/xRv90/src/build_api/BuildTargetSpec.jl:64
Stacktrace:
[1] (::BinaryBuilder2.var"#69#70"{String, BinaryBuilderPlatformExtensions.CrossPlatform, Set{Symbol}})(toolchain::BinaryBuilderToolchains.HostToolsToolchain)
@ BinaryBuilder2 ~/.julia/packages/BinaryBuilder2/xRv90/src/build_api/BuildTargetSpec.jl:33
[2] iterate
@ ./generator.jl:48 [inlined]
[3] collect_to!(dest::Vector{BinaryBuilderToolchains.CToolchain}, itr::Base.Generator{Vector{Union{BinaryBuilderToolchains.AbstractToolchain, BinaryBuilder2.PlatformlessWrapper{<:BinaryBuilderToolchains.AbstractToolchain}}}, BinaryBuilder2.var"#69#70"{String, BinaryBuilderPlatformExtensions.CrossPlatform, Set{Symbol}}}, offs::Int64, st::Int64)
@ Base ./array.jl:854
[4] collect_to_with_first!(dest::Vector{BinaryBuilderToolchains.CToolchain}, v1::BinaryBuilderToolchains.CToolchain, itr::Base.Generator{Vector{Union{BinaryBuilderToolchains.AbstractToolchain, BinaryBuilder2.PlatformlessWrapper{<:BinaryBuilderToolchains.AbstractToolchain}}}, BinaryBuilder2.var"#69#70"{String, BinaryBuilderPlatformExtensions.CrossPlatform, Set{Symbol}}}, st::Int64)
@ Base ./array.jl:832
[5] _collect(c::Vector{Union{BinaryBuilderToolchains.AbstractToolchain, BinaryBuilder2.PlatformlessWrapper{<:BinaryBuilderToolchains.AbstractToolchain}}}, itr::Base.Generator{Vector{Union{BinaryBuilderToolchains.AbstractToolchain, BinaryBuilder2.PlatformlessWrapper{<:BinaryBuilderToolchains.AbstractToolchain}}}, BinaryBuilder2.var"#69#70"{String, BinaryBuilderPlatformExtensions.CrossPlatform, Set{Symbol}}}, ::Base.EltypeUnknown, isz::Base.HasShape{1})
@ Base ./array.jl:826
[6] collect_similar
@ ./array.jl:738 [inlined]
[7] map
@ ./abstractarray.jl:3374 [inlined]
[8] BinaryBuilder2.BuildTargetSpec(name::String, platform::BinaryBuilderPlatformExtensions.CrossPlatform, toolchains::Vector{Any}, dependencies::Vector{Any}, flags::Set{Symbol})
@ BinaryBuilder2 ~/.julia/packages/BinaryBuilder2/xRv90/src/build_api/BuildTargetSpec.jl:28
```
I don't have a full enough view of the package to say that this is the
correct fix though.
|
I think this is only a problem because you're passing in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix the following error:
I don't have a full enough view of the package to say that this is the correct fix though.