Skip to content

OpenBLAS: Keep symlinks #11755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

OpenBLAS: Keep symlinks #11755

merged 1 commit into from
Aug 1, 2025

Conversation

eschnett
Copy link
Contributor

No description provided.

@eschnett
Copy link
Contributor Author

Closes #11748

@giordano giordano linked an issue Jul 31, 2025 that may be closed by this pull request
[OpenBLAS] Do not duplicate macOS library #11748
Closed
@imciner2 imciner2 merged commit a925239 into JuliaPackaging:master Aug 1, 2025
16 checks passed
@giordano
Copy link
Member

giordano commented Aug 1, 2025 •
edited
Loading

Somehow this didn't build for aarch64-freebsd: JuliaBinaryWrappers/OpenBLAS_jll.jl@b486d1e. Edit: ah, we only dropped the libgfortran4 version?

@imciner2
Copy link
Member

imciner2 commented Aug 1, 2025

Somehow this didn't build for aarch64-freebsd: JuliaBinaryWrappers/OpenBLAS_jll.jl@b486d1e. Edit: ah, we only dropped the libgfortran4 version?

Um... nothing changed in our recipe here that would cause that. We do discard libgfortran 3/4 for powerpc64le on 3.29.0, but it should have still built for aarch64 freebsd. Was there a change somewhere else that would affect building for that platform by default?

@eschnett
Copy link
Contributor Author

eschnett commented Aug 1, 2025

We could rebuild the OpenBLAS32 libraries as well. On the other hand we could just keep things as they are and wait for OpenBLAS 0.30.0.

@eschnett eschnett deleted the eschnett/OpenBLAS-keep-symlinks branch August 1, 2025 13:22
@imciner2
Copy link
Member

imciner2 commented Aug 1, 2025

Ah ha - BinaryBuilderBase.jl doesn't expand the gfortran versions for BSD aarch64 platforms to anything other than v5 as of 1.36.0 (6 months ago): JuliaPackaging/BinaryBuilderBase.jl#418.

@giordano
Copy link
Member

giordano commented Aug 1, 2025

Ah, ok, that's fine then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imciner2 imciner2 imciner2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OpenBLAS] Do not duplicate macOS library
3 participants
@eschnett @giordano @imciner2