-
Notifications
You must be signed in to change notification settings - Fork 667
[slope] update to 6.3.0 #12739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[slope] update to 6.3.0 #12739
Conversation
Head branch was pushed to by a user without write access
|
I don't really understand these errors: |
|
Almost all failures are on Julia >= 1.11. |
|
This is a known issue. Here is a possible workaround, borrowed from PR #12820: |
|
Thanks @fingolfin ! I'm trying now. |
|
Okay, progress! Now only Julia 1.14 fails, with a new message: |
|
Okay, it works! Please don't merge yet, I am going to try to update to the newest version of the library first |
|
Okay, this is good to go now (from my side at least)! |
|
Since Julia 1.12.4 is out know, maybe we should switch Yggdrasil to use it and then try to get rid of the workaround/hack here... @giordano ? |
|
👋 Just a friendly reminder about this PR. Is there any chance this could be merged? |
S/slope/build_tarballs.jl
Outdated
| install_license $WORKSPACE/srcdir/libslope/LICENSE | ||
| """ | ||
|
|
||
| # Workaround for haskey bug in Julia 1.11+: Empty weakdeps from Pkg stdlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try removing this again now? It should not be necessary anymore
|
Thanks @fingolfin ! |
Update slope to v6.2.0: https://github.com/jolars/libslope/releases/tag/v6.2.0