Skip to content

Conversation

@jolars
Copy link
Contributor

@jolars jolars commented Dec 8, 2025

@giordano giordano enabled auto-merge (squash) December 8, 2025 14:46
auto-merge was automatically disabled December 8, 2025 15:30

Head branch was pushed to by a user without write access

@jolars
Copy link
Contributor Author

jolars commented Dec 8, 2025

I don't really understand these errors:

ERROR: LoadError: MethodError: no method matching haskey(::Vector{Base.UUID}, ::String)
The function `haskey` exists, but no method is defined for this combination of argument types.

@jolars
Copy link
Contributor Author

jolars commented Dec 9, 2025

Almost all failures are on Julia >= 1.11.

@jolars jolars changed the title [slope] update to 6.2.0 [slope] update to 6.2.1 Dec 9, 2025
@fingolfin
Copy link
Member

This is a known issue. Here is a possible workaround, borrowed from PR #12820:

# Workaround for haskey bug in Julia 1.12: Empty weakdeps from Pkg stdlib
# The bug is triggered when a stdlib (like Pkg) has weakdeps and gets resolved
# as part of the dependency graph. The code tries to call haskey(p.deps, name)
# where p.deps is a Vector{UUID} but the code expects a Dict.
# By emptying weakdeps, we avoid the buggy code path in Pkg.Operations.fixups_from_projectfile!
uuidpkg = Base.UUID("44cfe95a-1eb2-52ea-b672-e2afdf69b78f")
for v in [v"1.12.0", v"1.13.0"]
    stdlibs = Pkg.Types.get_last_stdlibs(v)
    if haskey(stdlibs, uuidpkg)
        empty!(stdlibs[uuidpkg].weakdeps)
    end
end

@jolars
Copy link
Contributor Author

jolars commented Jan 7, 2026

Thanks @fingolfin ! I'm trying now.

@jolars
Copy link
Contributor Author

jolars commented Jan 8, 2026

Okay, progress! Now only Julia 1.14 fails, with a new message:

[07:08:40] CMake Warning at bindings/julia/CMakeLists.txt:3 (find_package):
[07:08:40]   By not providing "FindJlCxx.cmake" in CMAKE_MODULE_PATH this project has
[07:08:40]   asked CMake to find a package configuration file provided by "JlCxx", but
[07:08:40]   CMake did not find one.
[07:08:40] 
[07:08:40]   Could not find a package configuration file provided by "JlCxx" with any of
[07:08:40]   the following names:
[07:08:40] 
[07:08:40]     JlCxxConfig.cmake
[07:08:40]     jlcxx-config.cmake
[07:08:40] 
[07:08:40]   Add the installation prefix of "JlCxx" to CMAKE_PREFIX_PATH or set
[07:08:40]   "JlCxx_DIR" to a directory containing one of the above files.  If "JlCxx"
[07:08:40]   provides a separate development package or SDK, be sure it has been
[07:08:40]   installed.
[07:08:40] 
[07:08:40] 
[07:08:40] CMake Error at bindings/julia/CMakeLists.txt:4 (get_target_property):
[07:08:40]   get_target_property() called with non-existent target
[07:08:40]   "JlCxx::cxxwrap_julia".
[07:08:40] 
[07:08:40] 
[07:08:40] CMake Error at bindings/julia/CMakeLists.txt:5 (get_filename_component):
[07:08:40]   get_filename_component called with incorrect number of arguments

@jolars
Copy link
Contributor Author

jolars commented Jan 8, 2026

Okay, it works! Please don't merge yet, I am going to try to update to the newest version of the library first

@jolars jolars changed the title [slope] update to 6.2.1 [slope] update to 6.3.0 Jan 8, 2026
@jolars
Copy link
Contributor Author

jolars commented Jan 8, 2026

Okay, this is good to go now (from my side at least)!

@ViralBShah ViralBShah requested a review from fingolfin January 8, 2026 16:49
@fingolfin
Copy link
Member

Since Julia 1.12.4 is out know, maybe we should switch Yggdrasil to use it and then try to get rid of the workaround/hack here... @giordano ?

@jolars
Copy link
Contributor Author

jolars commented Jan 23, 2026

👋 Just a friendly reminder about this PR. Is there any chance this could be merged?

install_license $WORKSPACE/srcdir/libslope/LICENSE
"""

# Workaround for haskey bug in Julia 1.11+: Empty weakdeps from Pkg stdlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try removing this again now? It should not be necessary anymore

@fingolfin fingolfin merged commit b9152ee into JuliaPackaging:master Jan 23, 2026
17 checks passed
@jolars
Copy link
Contributor Author

jolars commented Jan 23, 2026

Thanks @fingolfin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants