Skip to content

Conversation

@eschnett
Copy link
Contributor

No description provided.

@eschnett eschnett marked this pull request as draft December 19, 2025 22:32
@eschnett eschnett marked this pull request as ready for review December 19, 2025 22:32
Comment on lines +47 to +49
# We need at least GCC 10 for C++17
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies;
clang_use_lld=false, julia_compat="1.6", preferred_gcc_version=v"11")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need at least GCC 10, then why build with GCC 11?

Comment on lines +4 to +7
version = v"1.10.0"

sources = [
GitSource("https://github.com/lanl/singularity-eos", "82df6cff9ca8b16f8468f20b9d1eaeff60ac53c7"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems they just made a new release, perhaps you want that? :-)

Suggested change
version = v"1.10.0"
sources = [
GitSource("https://github.com/lanl/singularity-eos", "82df6cff9ca8b16f8468f20b9d1eaeff60ac53c7"),
version = v"1.11.0"
sources = [
GitSource("https://github.com/lanl/singularity-eos", "c996f6505161618f9ca9663942e0beef738b0ecc"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants