Skip to content

[LLVM] add 12.0.1 #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2021
Merged

[LLVM] add 12.0.1 #3313

merged 1 commit into from
Jul 17, 2021

Conversation

vchuravy
Copy link
Member

No description provided.

@vchuravy
Copy link
Member Author

needs JuliaPackaging/BinaryBuilderBase.jl#164

@giordano
Copy link
Member

needs JuliaPackaging/BinaryBuilderBase.jl#164

Why? The only failure I see looks unrelated

@vchuravy
Copy link
Member Author

Oops it is of course JuliaPackaging/BinaryBuilderBase.jl#157

@giordano
Copy link
Member

You should insist there, Elliot didn't look too much convinced 😛

@vchuravy vchuravy requested a review from staticfloat July 11, 2021 14:40
@giordano
Copy link
Member

Can you checkout https://github.com/giordano/BinaryBuilderBase.jl.git#mg/csl_paths in this branch so that we can see if JuliaPackaging/BinaryBuilderBase.jl#157 breaks anything? If it doesn't that could be an argument in favour of the change 🙂 (Yes, I'm suggesting testing in production 😁)

@giordano
Copy link
Member 

sandbox:${WORKSPACE}/build # echo $LD_LIBRARY_PATH 
/usr/lib/csl-musl-x86:/usr/lib/csl-glibc-x86:/usr/lib/csl-musl-i686_64:/usr/lib/csl-glibc-i686_64:/usr/local/lib64:/usr/local/lib:/usr/lib64:/usr/lib:/lib64:/lib:/workspace/x86_64-linux-musl-cxx11/destdir/lib:/opt/x86_64-linux-musl/x86_64-linux-musl/lib64:/opt/x86_64-linux-musl/x86_64-linux-musl/lib:/opt/aarch64-apple-darwin20/aarch64-apple-darwin20/lib:/opt/aarch64-apple-darwin20/lib:/workspace/destdir/lib64:/workspace/destdir/lib
sandbox:${WORKSPACE}/build # ls /usr/lib/csl-musl-x86
ls: /usr/lib/csl-musl-x86: No such file or directory
sandbox:${WORKSPACE}/build # ls /usr/lib/csl-glibc-x86
ls: /usr/lib/csl-glibc-x86: No such file or directory
sandbox:${WORKSPACE}/build # ls /usr/lib/csl-musl-i686_64
ls: /usr/lib/csl-musl-i686_64: No such file or directory
sandbox:${WORKSPACE}/build # ls /usr/lib/csl-glibc-i686_64
ls: /usr/lib/csl-glibc-i686_64: No such file or directory

Well, I guess we need first to fix the CSL paths to point to something existing...

@giordano giordano force-pushed the vc/llvm12.0.1 branch 3 times, most recently from 0c7fcb1 to 2dafb8a Compare July 12, 2021 23:34
@giordano
Copy link
Member

giordano commented Jul 12, 2021 •
edited
Loading

aarch64-apple-darwin is still failing 😞

Edit: it turns out the CSL libraries have the wrong version of libstdc++: JuliaPackaging/BinaryBuilderBase.jl#165 (comment). I think I'll need to review the Rootfs recipe, seems to be doing something fishy. Edit: #3327

@giordano giordano force-pushed the vc/llvm12.0.1 branch 3 times, most recently from 20cae8d to a345ba3 Compare July 14, 2021 00:46
@vchuravy vchuravy force-pushed the vc/llvm12.0.1 branch 2 times, most recently from c62a77c to f243120 Compare July 14, 2021 13:20
giordano
giordano reviewed Jul 14, 2021
View reviewed changes
@vchuravy vchuravy force-pushed the vc/llvm12.0.1 branch 3 times, most recently from b18bd8b to 74d2a4a Compare July 15, 2021 19:33
@vchuravy
Copy link
Member Author

cc: @femtomc for MLIR

@vchuravy
Copy link
Member Author

@Gnimuc does this look like it has the things you need?

@Gnimuc Gnimuc mentioned this pull request Jul 17, 2021
Merged
@vchuravy vchuravy marked this pull request as ready for review July 17, 2021 20:18
@vchuravy vchuravy enabled auto-merge (squash) July 17, 2021 20:18
@vchuravy vchuravy merged commit 3824fe0 into master Jul 17, 2021
@vchuravy vchuravy deleted the vc/llvm12.0.1 branch July 17, 2021 21:15
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
@vchuravy @simeonschaub
[LLVM] add 12.0.1 (JuliaPackaging#3313)
49fb823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giordano giordano giordano left review comments

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vchuravy @giordano