Skip to content

Reference Dagger.EAGER_THUNK_STREAMS explicitly #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Reference Dagger.EAGER_THUNK_STREAMS explicitly #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
329e8be
Reference Dagger.EAGER_THUNK_STREAMS explicitly
JamesWrigley Mar 13, 2024
73c62dc
Use Base.promote_op() instead of Base._return_type()
JamesWrigley Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sch/eager.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ function eager_cleanup(state, uid)
delete!(state.thunk_dict, tid)
end
remotecall_wait(1, uid) do uid
lock(EAGER_THUNK_STREAMS) do global_streams
lock(Dagger.EAGER_THUNK_STREAMS) do global_streams
if haskey(global_streams, uid)
delete!(global_streams, uid)
end
Expand Down
2 changes: 1 addition & 1 deletion src/submission.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ end
function EagerThunkMetadata(spec::EagerTaskSpec)
f = chunktype(spec.f).instance
arg_types = ntuple(i->chunktype(spec.args[i][2]), length(spec.args))
return_type = Base._return_type(f, Base.to_tuple_type(arg_types))
return_type = Base.promote_op(f, arg_types...)
return EagerThunkMetadata(return_type)
end
chunktype(t::EagerThunk) = t.metadata.return_type
Expand Down